Skip to content

Add support for CLI kebab case flag.#489

Merged
hramezani merged 6 commits intopydantic:mainfrom
kschwab:cli-kebab-case
Dec 3, 2024
Merged

Add support for CLI kebab case flag.#489
hramezani merged 6 commits intopydantic:mainfrom
kschwab:cli-kebab-case

Conversation

@kschwab
Copy link
Copy Markdown
Contributor

@kschwab kschwab commented Dec 1, 2024

Fixes #469.

Copy link
Copy Markdown
Contributor

@hyperlint-ai-deprecated hyperlint-ai-deprecated bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]ubcommand

@kschwab kschwab marked this pull request as draft December 2, 2024 04:11
@kschwab kschwab marked this pull request as ready for review December 3, 2024 05:46
@hramezani
Copy link
Copy Markdown
Member

Thanks @kschwab for this PR.
The changes LGTM 👍 . let's wait for @braindevices feedback on the issue

@braindevices
Copy link
Copy Markdown

@kschwab thanks a lot! it is perfect now.

@hramezani hramezani merged commit 7bcb6ed into pydantic:main Dec 3, 2024
@kschwab kschwab deleted the cli-kebab-case branch December 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is there way to make both --opt-with-dash and environment variable work at the same time?

3 participants