CodSpeed Performance Report

Merging #9896 will not alter performance

_{Comparing Youssefares:types/zoneinfo (57e85b7) with main (7cf8239)}

Summary

✅ 14 untouched benchmarks

hey @Youssefares correct me if i'm wrong but i guess its similar to this one we have in Pydantic-extra pydantic/pydantic-extra-types#193

hey @Youssefares correct me if i'm wrong but i guess its similar to this one we have in Pydantic-extra pydantic/pydantic-extra-types#193

This does seem very similar, zoneinfo.ZoneInfo is part of the python std library though. I maybe wrong but my understanding of pydantic-extra-types is that it defines additional convenience types, while pydantic itself is where we offer support for standard types. I am not 100% sure about the need for an extra-type in this scenario given zoneinfo now exists since 3.9. I also think (in my experience at least), most people try to drop the pytz dependency from their project nowadays if zoneinfo does the job.

I'll leave to maintainers to decide whether the extra type using pytz is still required, but I believe supporting zoneinfo is very much worthwhile eitherway.

hey @Youssefares correct me if i'm wrong but i guess its similar to this one we have in Pydantic-extra pydantic/pydantic-extra-types#193

This does seem very similar, zoneinfo.ZoneInfo is part of the python std library though. I maybe wrong but my understanding of pydantic-extra-types is that it defines additional convenience types, while pydantic itself is where we offer support for standard types. I am not 100% sure about the need for an extra-type in this scenario given zoneinfo now exists since 3.9. I also think (in my experience at least), most people try to drop the pytz dependency from their project nowadays if zoneinfo does the job.

I'll leave to maintainers to decide whether the extra type using pytz is still required, but I believe supporting zoneinfo is very much worthwhile eitherway.

Yes as you said the best answer we can have is from maintainers themselves.

cc @sydney-runkle @samuelcolvin

please review

Exciting stuff here - this is next in my queue to review :). Should be able to get to it this evening or first thing tomorrow :).

I'll leave to maintainers to decide whether the extra type using pytz is still required, but I believe supporting zoneinfo is very much worthwhile eitherway.

I think we should definitely just stick to std lib support, so the zoneinfo addition here is great!

CI's failing because this issue #9761 been resurrected somehow it seems? Looking into it..

That looks better.. 🟢 ✅