Fix Secret serialization schema, applicable for unions#9240
Merged
sydney-runkle merged 2 commits intomainfrom Apr 16, 2024
Merged
Fix Secret serialization schema, applicable for unions#9240sydney-runkle merged 2 commits intomainfrom
Secret serialization schema, applicable for unions#9240sydney-runkle merged 2 commits intomainfrom
Conversation
1 task
Contributor
Author
|
Please review |
Deploying pydantic-docs with
|
| Latest commit: |
6673dc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d35bcec.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-secret-ser.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #9240 will not alter performanceComparing Summary
|
hramezani
approved these changes
Apr 15, 2024
davidhewitt
reviewed
Apr 16, 2024
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
The fix here seems a bit magical to me, can you give a bit more detail on why the original schema was wrong? I wonder if there's a deeper bug or otherwise awkward behaviour...
Contributor
Author
|
I think there's a deeper bug, that the serialization attached to the individual Will report this in core. |
Contributor
Author
|
Opened an issue here to address that bug in core, but this should work for now. Here's that issue: pydantic/pydantic-core#1270 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9231
Selected Reviewer: @hramezani