Revert typing.Literal and import it outside the TYPE_CHECKING block#9232
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom Apr 14, 2024
Merged
Conversation
Contributor
Author
|
please review |
CodSpeed Performance ReportMerging #9232 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Apr 14, 2024
Contributor
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
In PR #7680 the
typing.Literalwas replaced withtyping_extensions.Literal. I was curious enough to double-check the origin and found that the error was caused by importingfrom typing import Literalinside the TYPE_CHECKING block but then using it outside the scope.I suggest to revert
typing.Literalback, but importing it correctly at the module level. This meets the required Python 3.8+ limitation and works well with the example from the original issue:Related issue number
refs #7623
Checklist
Selected Reviewer: @dmontagu