Skip to content

Use the globals of the function when evaluating the return type for PlainSerializer and WrapSerializer functions#11008

Merged
sydney-runkle merged 1 commit intomainfrom
func-rt-2
Dec 2, 2024
Merged

Use the globals of the function when evaluating the return type for PlainSerializer and WrapSerializer functions#11008
sydney-runkle merged 1 commit intomainfrom
func-rt-2

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Nov 30, 2024

Fixes #11004, follow up on #10929.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Nov 30, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Nov 30, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b8caad
Status: ✅  Deploy successful!
Preview URL: https://d6d377f4.pydantic-docs.pages.dev
Branch Preview URL: https://func-rt-2.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #11008 will not alter performance

Comparing func-rt-2 (9b8caad) with main (8db4072)

Summary

✅ 46 untouched benchmarks

…PlainSerializer` and `WrapSerializer` functions
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks for adding those descriptive comments.

Namespace stuff is so challenging.

@sydney-runkle sydney-runkle merged commit b25095f into main Dec 2, 2024
@sydney-runkle sydney-runkle deleted the func-rt-2 branch December 2, 2024 15:49
sydney-runkle pushed a commit that referenced this pull request Dec 3, 2024
…PlainSerializer` and `WrapSerializer` functions (#11008)
qin-yu added a commit to qin-yu/spec-bioimage-io that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model is not fully defined together with from __future__ import annotations (Started in version 2.10.0)

2 participants