Merged
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
5ab7f38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa7af8a1.pydantic-docs.pages.dev |
| Branch Preview URL: | https://inc-ex-ann.pydantic-docs.pages.dev |
Viicos
commented
Sep 6, 2024
| # Keep these type aliases available at runtime: | ||
| TupleGenerator: TypeAlias = Generator[Tuple[str, Any], None, None] | ||
| # Keep this type alias in sync with the stub definition in `pydantic-core`: | ||
| IncEx: TypeAlias = 'set[int] | set[str] | dict[int, IncEx | bool] | dict[str, IncEx | bool]' |
Member
Author
There was a problem hiding this comment.
I removed the | None and added it in the relevant method signatures, as it makes more sense imo to keep the type alias scoped to what it represents, and then have consumers of this type alias make it optional or not.
CodSpeed Performance ReportMerging #10339 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Sep 6, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks good. What happened to ModelT?
| # Keep these type aliases available at runtime: | ||
| TupleGenerator: TypeAlias = Generator[Tuple[str, Any], None, None] | ||
| # Keep this type alias in sync with the stub definition in `pydantic-core`: | ||
| IncEx: TypeAlias = 'set[int] | set[str] | dict[int, IncEx | bool] | dict[str, IncEx | bool]' |
Member
Author
I moved it just above the |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
added a commit
that referenced
this pull request
Sep 9, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #10333
Requires pydantic/pydantic-core#1443
Ideally we would import
_IncExfrompydantic-core, but some external tools requires these annotations to be available at runtime :/Checklist