adds test case for unexpected discriminated union behavior#9236
Merged
sydney-runkle merged 4 commits intopydantic:mainfrom Apr 23, 2024
Merged
adds test case for unexpected discriminated union behavior#9236sydney-runkle merged 4 commits intopydantic:mainfrom
sydney-runkle merged 4 commits intopydantic:mainfrom
Conversation
CodSpeed Performance ReportMerging #9236 will not alter performanceComparing Summary
|
9485af0 to
9da09f8
Compare
Contributor
|
Thanks for adding the test case! Please remove all of the other changes made in this PR (reformatting), etc |
Contributor
Author
|
Ah can I just do make format for that?
…On Sat, Apr 13, 2024 at 17:22 Sydney Runkle ***@***.***> wrote:
Thanks for adding the test case! Please remove all of the other changes
made in this PR (reformatting), etc
—
Reply to this email directly, view it on GitHub
<#9236 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5CBQT4PIORQ4P57S3QSVG3Y5HD4ZAVCNFSM6AAAAABGE5EMHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTHAYTMNBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
@kf-novi I believe so, or just revert the commit + add back the test if that doesn't work |
This reverts commit 9da09f8.
Contributor
Author
|
Sorry about the dual account thing here, opened with this one and keep forgetting which one I'm using. Anyway, had to revert since my auto-formatter added a bunch of commas that ruff format doesn't remove. So, should be good now. |
Contributor
|
Maybe add an |
Contributor
|
I will do that tomorrow!
…On Thu, Apr 18, 2024 at 17:50 Sydney Runkle ***@***.***> wrote:
@kf-novi <https://github.com/kf-novi>,
Maybe add an xfail with a link to your issue, then we can merge this?
—
Reply to this email directly, view it on GitHub
<#9236 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACUWLA2PSYGEWXJOM6PKMLY6BS5XAVCNFSM6AAAAABGE5EMHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGU2TIMRWGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
sydney-runkle
approved these changes
Apr 23, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Nice, including this in the patch and hoping we can get a fix for this in 2.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds failing test case for expected behavior in discriminated union
model_dumpRelated issue number
#9235
Checklist