Conversation
CodSpeed Performance ReportMerging #10922 will not alter performanceComparing Summary
|
davidhewitt
left a comment
There was a problem hiding this comment.
Seems correct with one simplification.
Viicos
left a comment
There was a problem hiding this comment.
Looks good, hopefully we'll soon be able to rework this annotation application because the function-wrap check is quite unfortunate
|
I used to be able to use FileURL for AnyUrl in my models (I have a field that can literally be AnyUrl, including file ones)... Should I make a separate issue or does this also fix that? Is there a way we can have a test for that use-case? |
yes, very much so, I'd like to rework the url types more - I think we could still reconsider validation on init, or at least go about it in a different way |
Deploying pydantic-docs with
|
| Latest commit: |
21b2401
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e7b8150.pydantic-docs.pages.dev |
| Branch Preview URL: | https://urls-str-constraints.pydantic-docs.pages.dev |
|
The issue is that |
OK I can do that. Is host required now only on 2.10 or was it required before but just not failing validation? |
Fix #10914