Fix variance issue in _IncEx type alias, only allow True#10414
Merged
sydney-runkle merged 4 commits intomainfrom Sep 16, 2024
Merged
Fix variance issue in _IncEx type alias, only allow True#10414sydney-runkle merged 4 commits intomainfrom
_IncEx type alias, only allow True#10414sydney-runkle merged 4 commits intomainfrom
Conversation
5670bbe to
ba299e0
Compare
Deploying pydantic-docs with
|
| Latest commit: |
dd81218
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18f5c34f.pydantic-docs.pages.dev |
| Branch Preview URL: | https://inc-ex-ann-2.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10414 will degrade performances by 12.56%Comparing Summary
Benchmarks breakdown
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
sydney-runkle
suggested changes
Sep 16, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Could you please add some info to the docs re the fact that we only support True? Thanks!
sydney-runkle
approved these changes
Sep 16, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
LGTM, pending test passes :)
sydney-runkle
added a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: sydney-runkle <sydneymarierunkle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #10335
Requires pydantic/pydantic-core#1453
Related issue number
Checklist