Print project link eagerly from credentials file if possible#1393
Merged
alexmojaki merged 9 commits intomainfrom Sep 10, 2025
Merged
Print project link eagerly from credentials file if possible#1393alexmojaki merged 9 commits intomainfrom
alexmojaki merged 9 commits intomainfrom
Conversation
Deploying logfire-docs with
|
| Latest commit: |
3a4e8e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://540bb557.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-skip-check-token.logfire-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements eager printing of the Logfire project URL from a credentials file when available, instead of waiting for asynchronous token validation.
- Modified the configuration logic to attempt loading credentials file first and print project URL immediately if available
- Updated token precedence to ensure environment variables still take priority over credentials file tokens
- Added comprehensive test coverage for various credential scenarios including invalid files and token precedence
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| logfire/_internal/config.py | Restructured credential loading logic to print project URL eagerly from credentials file when possible |
| tests/test_configure.py | Updated existing tests and added new test cases to verify eager URL printing and token precedence behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Kludex
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/pydantic/issue/PYD-2309/print-logfire-project-url-eagerly