fix: fix LOGFIRE_IGNORE_NO_CONFIG to prevent warning from LogFireConf…#1379
Merged
alexmojaki merged 6 commits intopydantic:mainfrom Sep 10, 2025
Merged
fix: fix LOGFIRE_IGNORE_NO_CONFIG to prevent warning from LogFireConf…#1379alexmojaki merged 6 commits intopydantic:mainfrom
alexmojaki merged 6 commits intopydantic:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
LucasSantos27
left a comment
There was a problem hiding this comment.
tip: instead of creating a new commit, you can run git commit --amend to add to the same commit
76d857a to
f2200da
Compare
LucasSantos27
approved these changes
Sep 7, 2025
Contributor
LucasSantos27
left a comment
There was a problem hiding this comment.
small fixes, good job!
alexmojaki
reviewed
Sep 8, 2025
logfire/_internal/config.py
Outdated
Comment on lines
+1200
to
+1201
| ignore_no_config_env = os.getenv('LOGFIRE_IGNORE_NO_CONFIG') | ||
| ignore_no_config = (ignore_no_config_env == '1') or self.ignore_no_config |
Collaborator
There was a problem hiding this comment.
Suggested change
| ignore_no_config_env = os.getenv('LOGFIRE_IGNORE_NO_CONFIG') | |
| ignore_no_config = (ignore_no_config_env == '1') or self.ignore_no_config | |
| ignore_no_config_env = os.getenv('LOGFIRE_IGNORE_NO_CONFIG', '') | |
| ignore_no_config = ignore_no_config_env.lower() in ('1', 'true', 't') or self.ignore_no_config |
alexmojaki
reviewed
Sep 8, 2025
tests/test_logfire.py
Outdated
Comment on lines
+3497
to
+3502
| with warnings.catch_warnings(record=True) as warning_list: | ||
| warnings.simplefilter('always') | ||
| config.warn_if_not_initialized('Should not warn with env var') | ||
|
|
||
| logfire_warnings = [w for w in warning_list if issubclass(w.category, LogfireNotConfiguredWarning)] | ||
| assert len(logfire_warnings) == 0 |
Collaborator
There was a problem hiding this comment.
Suggested change
| with warnings.catch_warnings(record=True) as warning_list: | |
| warnings.simplefilter('always') | |
| config.warn_if_not_initialized('Should not warn with env var') | |
| logfire_warnings = [w for w in warning_list if issubclass(w.category, LogfireNotConfiguredWarning)] | |
| assert len(logfire_warnings) == 0 | |
| config.warn_if_not_initialized('Should not warn with env var') |
This is enough, if there was a warning pytest would raise an error.
alexmojaki
reviewed
Sep 8, 2025
tests/test_logfire.py
Outdated
Comment on lines
+3525
to
+3529
| with warnings.catch_warnings(record=True) as warning_list: | ||
| warnings.simplefilter('always') | ||
|
|
||
| logfire_warnings = [w for w in warning_list if issubclass(w.category, LogfireNotConfiguredWarning)] | ||
| assert len(logfire_warnings) == 0 |
Collaborator
There was a problem hiding this comment.
again, no need for all this to check for a lack of warnings, but you haven't even got anything here that might emit a warning
alexmojaki
reviewed
Sep 8, 2025
tests/test_logfire.py
Outdated
Comment on lines
+3521
to
+3522
| logfire_warnings = [w for w in warnings_list if issubclass(w.category, LogfireNotConfiguredWarning)] | ||
| assert len(logfire_warnings) == 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| logfire_warnings = [w for w in warnings_list if issubclass(w.category, LogfireNotConfiguredWarning)] | |
| assert len(logfire_warnings) == 1 | |
| assert len(warnings_list) == 1 |
if there's a different kind of warning, pytest will raise an error, since you have pytest.warns(LogfireNotConfiguredWarning).
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. I have updated the code to include these changes.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for the issue described in #1331