Make zstd import optional on Python 3.14#1000
Merged
Merged
Conversation
On Python 3.14, `compression.zstd` requires the `_zstd` C extension, which is not present in every CPython build. Importing it unconditionally crashed `import httpx2` with `ModuleNotFoundError: No module named '_zstd'`. Wrap the import in try/except so zstd support degrades gracefully.
|
Docs preview: https://4b8a7475-httpx2-docs.pydantic.workers.dev |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3.14,
compression.zstdrequires the_zstdC extension, which is not present in every CPython build. We imported it unconditionally, soimport httpx2crashed withModuleNotFoundError: No module named '_zstd'on those builds.This wraps the 3.14 import in
try/except ImportError(mirroring the existing< 3.14branch), so a missing_zstdsets_zstandard_installed = Falseand dropszstdfromSUPPORTED_DECODERSinstead of crashing.Fixes the report in #999 (comment).
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.