chore: replace black with ruff in clean.sh#2448
Merged
DanielNoord merged 3 commits intoNov 10, 2025
Merged
Conversation
23c232e to
658c7af
Compare
658c7af to
9a63780
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
- Coverage 99.25% 99.25% -0.01%
==========================================
Files 40 40
Lines 3094 3089 -5
Branches 681 680 -1
==========================================
- Hits 3071 3066 -5
Misses 13 13
Partials 10 10 🚀 New features to boost your workflow:
|
DanielNoord
reviewed
Nov 7, 2025
DanielNoord
left a comment
Member
There was a problem hiding this comment.
It is kind of strange to me that the Lint job doesn't fail without this change. Is it possible that we also need to update that job so we also check everything in scripts for formatting?
Contributor
Author
|
Hey @DanielNoord, from my understanding the CI did not fail because the imports in scripts were already sorted and formatting was already covered by |
DanielNoord
approved these changes
Nov 10, 2025
f58e470 to
8a97221
Compare
8a97221 to
5cff82a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After running the
./scripts/done.shit reveled a lot of code formatting that should be fixed (+1321, -486). Then analyzing the workflow i noticed that we are actually using ruff. So instead of add the lint changes and i'm just going to update the clean script to use ruffRelated issue