Fix whitespace insensitive check triggering on tabs#2437
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 40 40
Lines 3090 3090
Branches 680 680
=======================================
Hits 3065 3065
Misses 14 14
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
approved these changes
Oct 21, 2025
DanielNoord
left a comment
Member
There was a problem hiding this comment.
Nice job! Again, only one a comment about the typing in the test.
58f3ac8 to
1199141
Compare
Contributor
Author
|
Type annotated and squashed. Ready for another review @DanielNoord |
DanielNoord
approved these changes
Oct 24, 2025
DanielNoord
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to fix that annotation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This amends #898 as tabs (
\t) are also considered whitespace in Python.Found while working on #1966