Fix #1964: lines_before_import sometimes ignored#1965
Conversation
|
@timothycrosley this is ready for review. It'd be great if this could be discussed and resolved before it starts lacking behind even more. |
|
@robsdedude Are you still interested in pursuing this? We could rebase this and get this reviewed :) |
|
Hi @DanielNoord, yes please. I've been patiently waiting for a review :) I've merged main into the PR so it's ready for a review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 40 40
Lines 3105 3106 +1
Branches 681 681
=======================================
+ Hits 3080 3081 +1
Misses 14 14
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
left a comment
There was a problem hiding this comment.
One comment/nit about typing in the tests. Otherwise LGTM and I'll merge after that is fixed :)
|
@robsdedude Since we use the merge queue I can't squash your commits myself. Could you perhaps squash the commits so I can merge this into |
The config option `lines_before_import` was ignored if the file only contained imports + optionally a leading comment.
e39c314 to
043261f
Compare
|
Sorry, I missed the ping that this was squashed. Thanks for the fix! |
The config option
lines_before_importwas ignored if the file only containedimports + optionally a leading comment.
Fixes #1964