Handle exceptions in set_tlsext_servername_callback callbacks#1478
Merged
reaperhulk merged 1 commit intomainfrom Feb 17, 2026
Merged
Handle exceptions in set_tlsext_servername_callback callbacks#1478reaperhulk merged 1 commit intomainfrom
reaperhulk merged 1 commit intomainfrom
Conversation
When the servername callback raises an exception, call sys.excepthook with the exception info and return SSL_TLSEXT_ERR_ALERT_FATAL to abort the handshake. Previously, exceptions would propagate uncaught through the CFFI callback boundary. https://claude.ai/code/session_01P7y1XmWkdtC5UcmZwGDvGi
reaperhulk
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the servername callback raises an exception, call sys.excepthook with the exception info and return SSL_TLSEXT_ERR_ALERT_FATAL to abort the handshake. Previously, exceptions would propagate uncaught through the CFFI callback boundary.
https://claude.ai/code/session_01P7y1XmWkdtC5UcmZwGDvGi