ci: fix ci - remove append_as_bytes logic, misc changes#3861
Merged
nateberkopec merged 4 commits intopuma:mainfrom Jan 20, 2026
Merged
ci: fix ci - remove append_as_bytes logic, misc changes#3861nateberkopec merged 4 commits intopuma:mainfrom
append_as_bytes logic, misc changes#3861nateberkopec merged 4 commits intopuma:mainfrom
Conversation
schneems
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
append_as_byteslogic, which was causing failures in TruffleRuby head. The code was added when 6.6.1 was in development. A lot of has changed in Ruby when moving from 2.4 to 3.0, and encoding is much better in Ruby 3.0.Also, tightening up of a few tests, etc.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.