Skip to content

ci: Update test_http11.rb for TruffleRuby - string size#3860

Merged
MSP-Greg merged 1 commit intopuma:mainfrom
MSP-Greg:00-truffleruby-horrible
Jan 16, 2026
Merged

ci: Update test_http11.rb for TruffleRuby - string size#3860
MSP-Greg merged 1 commit intopuma:mainfrom
MSP-Greg:00-truffleruby-horrible

Conversation

@MSP-Greg
Copy link
Copy Markdown
Member

@MSP-Greg MSP-Greg commented Jan 14, 2026

Description

Fixes up #test_horrible_queries in test/test_http11.rb. This just affected TruffleRuby.

Typically, the error is Error: Process completed with exit code xxx. xxx` can vary.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg force-pushed the 00-truffleruby-horrible branch from 58c7b1f to d69fb47 Compare January 14, 2026 22:51
@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Jan 14, 2026
@MSP-Greg MSP-Greg force-pushed the 00-truffleruby-horrible branch from d69fb47 to 6ad8048 Compare January 15, 2026 02:45
@MSP-Greg MSP-Greg changed the title ci: Update test_http11.rb for TruffleRuby - strings? ci: Update test_http11.rb for TruffleRuby - string size Jan 15, 2026
Copy link
Copy Markdown
Member

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave you approval, will let you merge at will. Please also add the failing error message that you're fixing to the PR description for future investigation context.

@schneems schneems added waiting-for-merge and removed waiting-for-review Waiting on review from anyone labels Jan 16, 2026
@schneems schneems mentioned this pull request Jan 16, 2026
7 tasks
@MSP-Greg
Copy link
Copy Markdown
Member Author

@schneems

Thanks. Many of these tests are no longer working as expected, but they're passing for now.

@MSP-Greg MSP-Greg merged commit ec7dd61 into puma:main Jan 16, 2026
85 checks passed
@MSP-Greg MSP-Greg deleted the 00-truffleruby-horrible branch January 17, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants