Conversation
tgummerer
approved these changes
Mar 5, 2026
Contributor
|
This PR has been shipped in release v3.225.1. |
1 similar comment
Contributor
|
This PR has been shipped in release v3.225.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22096
In #21999 we changed the engine to handle the inheritance of providers, rather than having SDKs needing to do it. This was to help bringing online two new language runtimes.
Unfortunately we got the logic wrong when dealing with default providers. The language SDKs never see default providers so would never inherit them, but the engine does see them and so would flow them down the parent chain. This is fine for resources in the same package but breaks if you have a resource from say packageA as a parent and a resource from packageB as it's child.
Previously that would work as long as the resource from packageA didn't set an explicit provider as the language runtime would see "provider" as empty and so the resource from packageB would send an empty provider ref and both would get filled in by the engine with the default providers.
But when doing this inheritance engine side the engine always sees the provider value set, either the explicit value set by the program, or the default set by the engine. So we started flowing default providers down the parent chain.
The logic was also wrong for providers from different packages. Again the language SDKs check the provider package and only send it if it matches.
We can fix both of these problems by just fixing the latter one. That is don't inherit the provider if its for the wrong package.