Fix Go program generation lifting plains to input values#22084
Merged
Fix Go program generation lifting plains to input values#22084
Conversation
283e712 to
e07f304
Compare
iwahbe
approved these changes
Mar 5, 2026
Co-authored-by: Ian Wahbe <me@iwahbe.com>
Contributor
|
This PR has been shipped in release v3.225.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Go program generation to lift plain values like
stringto input/output values likepulumi.Stringin locations that is needed. Most directly this fixes the generation of the l1-builtin-secret test for Go as we now correctly lift thenotSecretvalue to be apulumi.String.As part of this I had to fix the
readFilehelper function to match what PCL binding expected it to be, a plain string, not an output string. This is so PCL binding added the correct__convertcalls, rather than it thinkingreadFilereturned a string, trying to cast it to an input and then failing because the Go helper was already an output.