Skip to content

Add --neo-task-on-failure flag#21960

Merged
VenelinMartinov merged 7 commits intomasterfrom
vvm/add_neo_task_on_failure_flag
Mar 3, 2026
Merged

Add --neo-task-on-failure flag#21960
VenelinMartinov merged 7 commits intomasterfrom
vvm/add_neo_task_on_failure_flag

Conversation

@VenelinMartinov
Copy link
Copy Markdown
Contributor

@VenelinMartinov VenelinMartinov commented Feb 25, 2026 •
edited
Loading

This PR adds a --neo-task-on-failure flag to preview and up and a NEO_TASK_ON_FAILURE env var to trigger the same. This will automatically open a Neo task with the error logs if a preview or up fails.

This one has no interactive prompts and should change nothing for people who don't specify it.

Resources:
    + 12 to create
    1 unchanged
    2 errored


Neo Task Created ✨
  A Neo task has been started to help debug this error.
  https://app.pulumi.com/pulumi/neo/tasks/09968614-483d-4544-bcd6-5fb6c3db770c

We need this for Deployments, where the only way to influence the CLI is via environment variables.

@VenelinMartinov VenelinMartinov requested a review from a team as a code owner February 25, 2026 17:53
@VenelinMartinov
Copy link
Copy Markdown
Contributor Author

VenelinMartinov commented Feb 25, 2026

This change is part of the following stack:

Change managed by git-spice.

@VenelinMartinov VenelinMartinov marked this pull request as draft February 25, 2026 17:53
@VenelinMartinov VenelinMartinov marked this pull request as ready for review February 25, 2026 18:03
Frassle
Frassle reviewed Feb 25, 2026
View reviewed changes
Comment thread sdk/go/common/env/env.go Outdated
tgummerer
tgummerer reviewed Feb 26, 2026
View reviewed changes
Comment thread pkg/backend/display/ai_test.go Outdated
Comment thread pkg/backend/httpstate/client/client_test.go Outdated
Comment thread pkg/backend/httpstate/client/client_test.go Outdated
Comment thread pkg/backend/httpstate/backend.go
Comment thread pkg/backend/httpstate/backend.go Outdated
Comment thread pkg/backend/httpstate/client/client.go
Comment thread pkg/backend/display/ai.go Outdated
Comment thread pkg/backend/display/ai.go Outdated
Comment thread pkg/backend/httpstate/client/client.go
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_neo_task_on_failure_flag branch from 76bb2d7 to faa8afb Compare February 27, 2026 14:56
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_neo_task_on_failure_flag branch 2 times, most recently from 02f7ce2 to 8391e18 Compare February 27, 2026 17:40
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_neo_task_on_failure_flag branch from 8391e18 to 907fef1 Compare February 27, 2026 18:07
tgummerer
tgummerer reviewed Mar 2, 2026
View reviewed changes
Comment thread pkg/cmd/pulumi/operations/io_test.go Outdated
@VenelinMartinov VenelinMartinov added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@VenelinMartinov VenelinMartinov added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@VenelinMartinov VenelinMartinov added this pull request to the merge queue Mar 3, 2026
Merged via the queue into master with commit 91eda00 Mar 3, 2026
111 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/add_neo_task_on_failure_flag branch March 3, 2026 15:55
@pulumi-bot
Copy link
Copy Markdown
Contributor

pulumi-bot commented Mar 4, 2026

This PR has been shipped in release v3.225.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgummerer tgummerer tgummerer approved these changes

@Frassle Frassle Awaiting requested review from Frassle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VenelinMartinov @pulumi-bot @tgummerer @Frassle