Ensure "parse" fuzz target covers all options#980
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Nov 6, 2024
Merged
Ensure "parse" fuzz target covers all options#980Martin1887 merged 1 commit intopulldown-cmark:masterfrom
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
Conversation
Collaborator
|
Nice! |
Collaborator
Author
|
Forgot to mention this does preclude using the |
Collaborator
Author
|
@kdarkhan in the README example you had put If we really wanted, it could be supported while keeping this option-agnostic via something like |
Contributor
|
I haven't really tested it much with fuzzing this project. I put the option only as an example of fixing the build and not as the suggested option. Feel free to remove it if it is misleading now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzz target
parse.rs(intended to find crashes/panics) was missing some newer options.Change to use
Options::from_bits_truncateto generate arbitrary combinations of all options, current and future.Not sure if the field order in the struct makes much difference, but I figured it's better to have the fixed length field first, so it doesn't move around and change unintentionally.
Tried it out, and it found #973 in under a minute (on v0.12.2 before the fix was merged).