Stop using scan_ch when get will do#1003
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Jan 11, 2025
Merged
Conversation
That scanner, which returns `usize`, makes sense when actual offset arithmetic is being done. But it's overkill for checking if a character exists. Since `slice::get` is in the standard library, use that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That scanner, which returns
usize, makes sense when actual offset arithmetic is being done. But it's overkill for checking if a character exists.Since
slice::getis in the standard library, use that.