fix(prefix): PrefixPrinter now uses updated defaultWriter#752
Merged
MarvinJWendt merged 1 commit intopterm:masterfrom Feb 25, 2026
Merged
fix(prefix): PrefixPrinter now uses updated defaultWriter#752MarvinJWendt merged 1 commit intopterm:masterfrom
MarvinJWendt merged 1 commit intopterm:masterfrom
Conversation
When calling pterm.SetDefaultOuput(writer), the prefix printers initialized by pterm did not use the new default. This commit changes this behaviour, and the prefix printers will now use whatever is set as the defaultWriter unless a specific writer has been set using the WithWriter(writer) method on the PrefixPrinter, in which case it will use that printer. Closes #751
Contributor
Author
|
There seems to be failures in the |
MarvinJWendt
approved these changes
Feb 25, 2026
Member
MarvinJWendt
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing 🚀
(Sorry for the delay)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling pterm.SetDefaultOuput(writer), the prefix printers initialized by pterm did not use the new default.
This commit changes this behaviour, and the prefix printers will now use whatever is set as the defaultWriter unless a specific writer has been set using the WithWriter(writer) method on the PrefixPrinter, in which case it will use that printer.
Fixes #751
Fixes #701