refactor: use strings.Builder to save memory#650
Merged
MarvinJWendt merged 4 commits intopterm:masterfrom Oct 4, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 81.05% 81.12% +0.06%
==========================================
Files 33 33
Lines 4176 4196 +20
==========================================
+ Hits 3385 3404 +19
- Misses 718 719 +1
Partials 73 73 ☔ View full report in Codecov by Sentry. |
MarvinJWendt
approved these changes
Aug 12, 2024
Member
MarvinJWendt
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing 🚀
strings.Builder to save memorystrings.Builder to save memory
Contributor
Author
|
Hello @MarvinJWendt , thanks for reviewing! I rebased this branch to the latest master, this could make the commit history more clear. All conflict in "table_printer.go" is fixed, you may take some time to review that file again. |
20845df to
3c5a3c1
Compare
Contributor
Author
|
I also fixed the linter issues. |
6f818d3 to
9a26d00
Compare
Contributor
Author
|
@MarvinJWendt |
e39729a to
9c560f6
Compare
Contributor
Author
|
Rebased. |
9c560f6 to
d582b75
Compare
MarvinJWendt
approved these changes
Oct 4, 2024
Member
|
Sorry for the long wait, I am quite busy with other stuff atm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649.