fix(spinner): remove extra newline on start#732
Merged
MarvinJWendt merged 1 commit intopterm:masterfrom Oct 1, 2025
Merged
Conversation
The spinner was printing an extra newline character upon starting, which caused layout issues in the terminal. The root cause is an unconditional `Fprintln` call in the `Start` method. This removes the extra `Fprintln` to resolve the issue. Closes pterm#731
MarvinJWendt
approved these changes
Oct 1, 2025
Member
MarvinJWendt
left a comment
There was a problem hiding this comment.
Sorry for the delay! LGTM!
Fixes #736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spinner was printing an extra newline character upon starting, which caused layout issues in the terminal. The root cause is an unconditional
Fprintlncall in theStartmethod.This removes the extra
Fprintlnto resolve the issue.Fixes #731