Fix cosmetic header validity parsing regex#7308
Merged
nateprewitt merged 1 commit intopsf:mainfrom Mar 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit to @ParzivalHack for reporting this through our security channel. This PR fixes what is now a cosmetic guard for header validity. It was originally introduced before the standard library handled line folding in http.client to protect older versions of Python. Now it serves as a cleaner error layer for callers of Requests.
This PR moves the end of regex from
$to\Zto capture any end-of-line LF characters. Those are explicitly ignored by$for convenience and our tests missed it. This change ensures our error is raised uniformly and we don't have standard library error messages sneaking though.