Skip to content

Remove mocking from tests#4287

Merged
hauntsaninja merged 4 commits intopsf:mainfrom
hauntsaninja:fix-test
Mar 21, 2024
Merged

Remove mocking from tests#4287
hauntsaninja merged 4 commits intopsf:mainfrom
hauntsaninja:fix-test

Conversation

@hauntsaninja
Copy link
Copy Markdown
Collaborator

Fixes #4275

@hauntsaninja hauntsaninja added the ci: skip news Pull requests that don't need a changelog entry. label Mar 20, 2024
Copy link
Copy Markdown
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always better to avoid mocking

@github-actions
Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (bd6d608) to main (bf11956).


What is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja merged commit c9d2635 into psf:main Mar 21, 2024
@hauntsaninja hauntsaninja deleted the fix-test branch March 21, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: skip news Pull requests that don't need a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unrelated testcases fail when total number of tests is increased beyond 367

2 participants