cleanup: reduce warnings on MSVC builds#15397
Merged
1 commit merged intoJan 11, 2024
Merged
Conversation
Protobuf sets the `/utf-8` flag in the linker, but this is a compiler flag [^1]. The linker emits a warning, polluting the logs for all downstream projects [^2] with many `LINK : warning LNK4044: unrecognized option '/utf-8'; ignored` lines. [^1]: https://learn.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-170 [^2]: For an example, see [this build](https://github.com/googleapis/google-cloud-cpp/actions/runs/7484447749/job/20371331322#step:5:4146) PiperOrigin-RevId: 597570083
8ab5766 to
c988f9c
Compare
c988f9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup: reduce warnings on MSVC builds
Protobuf sets the
/utf-8flag in the linker, but this is a compiler flag 1. The linker emits a warning, polluting the logs for all downstream projects 2 with manyLINK : warning LNK4044: unrecognized option '/utf-8'; ignoredlines.Footnotes
https://learn.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-170 ↩
For an example, see this build ↩