Fix some of the reflection based algorithms to handle Map entries properly.#14934
Merged
1 commit merged intoDec 7, 2023
Merged
Fix some of the reflection based algorithms to handle Map entries properly.#149341 commit merged into
1 commit merged into
Conversation
500c096 to
d5b2ae6
Compare
d5b2ae6 to
6065463
Compare
…perly. They should ignore presence and always process key and value. Remove codegen for methods in MapEntry and use the ones from Message. Delete dead code in MapTypeHandler. PiperOrigin-RevId: 588826780
6065463 to
2b45018
Compare
2b45018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some of the reflection based algorithms to handle Map entries properly.
They should ignore presence and always process key and value.
Remove codegen for methods in MapEntry and use the ones from Message.
Delete dead code in MapTypeHandler.