Fix somes warning when compiling with Visual Studio 2019 on x64 target#8125
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Dec 30, 2020
gvollant:bugfix/gvollant_warning_vs2019x64
Merged
Fix somes warning when compiling with Visual Studio 2019 on x64 target#8125acozzette merged 1 commit intoprotocolbuffers:masterfrom gvollant:bugfix/gvollant_warning_vs2019x64
acozzette merged 1 commit intoprotocolbuffers:masterfrom
gvollant:bugfix/gvollant_warning_vs2019x64
Conversation
Contributor
Author
|
These warning fixes are simple. |
Contributor
Author
|
@coryan @acozzette regards,gilles |
acozzette
reviewed
Dec 29, 2020
| GOOGLE_DCHECK(*ptr); | ||
| if (PROTOBUF_PREDICT_TRUE(*ptr < limit_end_)) return false; | ||
| int overrun = *ptr - buffer_end_; | ||
| size_t overrun = *ptr - buffer_end_; |
There was a problem hiding this comment.
I believe this has to be a signed type because overrun can be negative. Maybe std::ptrdiff_t would be the right type.
Contributor
There was a problem hiding this comment.
Consider: auto overrun = *ptr - buffer_end_;
Contributor
Author
There was a problem hiding this comment.
finally, I made a new commit with
int overrun = static_cast<int>(*ptr - buffer_end_);
overrun is used for compare with limit_ (which is int) and as first argument of DoneFallback (which expect int).
In visual studio 2019 x64 target, size_t are 64 bits and int are 32 bits
|
Thanks, @gvollant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In visual studio 2019 x64 target, pointer size and size_t are 64 bits and int are 32 bits
This commit uses size_t for buffer size