Remove ODR violation from WKT codegen (#12406)#12419
Merged
haberman merged 2 commits intoprotocolbuffers:22.xfrom Apr 6, 2023
Merged
Remove ODR violation from WKT codegen (#12406)#12419haberman merged 2 commits intoprotocolbuffers:22.xfrom
haberman merged 2 commits intoprotocolbuffers:22.xfrom
Conversation
Closes protocolbuffers#12406 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175
perezd
approved these changes
Apr 6, 2023
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…olbuffers#12419) * Remove ODR violation from WKT codegen (protocolbuffers#12406) Closes protocolbuffers#12406 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175 * Removed legacy target. --------- Co-authored-by: Mike Kruskal <mkruskal@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12406
COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e PiperOrigin-RevId: 522418175