Remove unused dependency GitPython#781
Remove unused dependency GitPython#781Pierre-Sassoulas merged 1 commit intoprospector-dev:masterfrom
Conversation
|
@cclauss do you rember why you add it? |
|
I think it was an indirect dependency. |
|
Hi again, |
|
I definitely remember situations where dependencies had version ranges which ended up allowing some indirect dependency which then caused things to break - so while prospector does not use it directly there might have been some strange set of conditions where this constraint was necessary despite it not being used directly. That's my vague guess at the reasons it was there, but I'm all for removing this. |
|
I failed to properly review the MR that introduced this, I should have asked or clarified the reason to add this dependency at the time. Gitpython is an optional dependency for pylint primer tests, that might be the reason it was added but multiple years later the historical context that might have been obvious at the time (another pr jobs failing perhaps ?) is lost and impliciteness is not enough anymore. |
Remove unused dependency GitPython
Description
GitPythondependency was removed frompoetry.lockandpyproject.tomlRelated Issue
#780
Motivation and Context
Unnecessary dependencies can introduce version conflicts, make maintenance harder and can increase the attack surface.
How Has This Been Tested?
Python 3.10.18 was used.
the following command for testing was executed:
Types of changes
Checklist: