Conversation
6adc0f0 to
1cc34fb
Compare
a9ba584 to
c79826f
Compare
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
A lot of work here, great job !
|
Awesome stuff :-) |
|
|
||
| @contextlib.contextmanager | ||
| def patch_execution(*args: str, set_cwd: Optional[Path] = None) -> Generator[None, None]: | ||
| def patch_execution(*args: str, set_cwd: Path | None = None) -> Generator[None, None]: |
There was a problem hiding this comment.
PEP 604 for union types using | wasn't added until Python 3.10 but prospector still supports 3.9 so I suggest reverting this line unless dropping 3.9 is the plan. Since 3.9 is not quite end of life yet, I'd like to avoid that.
Or is that wrong? Since CI seems to pass.
There was a problem hiding this comment.
I'm on mobile si it's hard to check but there might be an import from the future (form future import annotations)
There was a problem hiding this comment.
@Pierre-Sassoulas You're right, there is, I missed that since it was collapsed by the GitHub diff UI :-)
There was a problem hiding this comment.
Then finally it's OK :-)
Description
Check the tests files
Related Issue
#754 (comment)
Motivation and Context
Better coherence between the pre-commit and the Prospector command