@Pierre-Sassoulas I just added the test files in Prospector check :-)

It's worth pointing out that the .prospector.yml profile in this repo and default inherited profiles will still ignore tests - see the output of prospector --show-profile which still includes:

ignore-paths:
- docs/
ignore-patterns:
- ^docs?/
- ^tests?/?
- /tests?(/|$)
- .*/tests(/|$)
- (^|/)test_[_a-zA-Z0-9]+.py$
- (^|/)[_a-zA-Z0-9]+_tests?.py$
- (^|/)tests?.py
- ^setup.py$
- (^|/)\..+

However if you add test-warnings: yes to .prospector.yml then it will lint them and then there are a bunch of warnings

The logic of this originally was: if you lint everything it might overwhelm people and discourage them, so make it so only "medium or worse" things were highlighted and tests were not as important as the main code. The idea being it'd encourage fixing those, then turning on more linting later. I think that's still valid, since prospector was meant to be the 'gateway' tool before really starting to configure pylint and flake8 and so on though the landscape has changed a lot since I made that design choice!

Then we should (one of them):

• Revert Don't filter manual selected file #707 because it's in contradiction on how pre-commit works.
• Set pass_filenames to false.

What do you think?

Why not simple update the prospector profile to have test-warnings; yes? That works with current master (when running pre-commit run --all) to lint the tests, and will be consistent for manually running prospector too.

For is it's working effectively, but for the other I think that set pass_filenames to false can be a not bad possibility? I also notice that some tool like mypy change the results when the list changes, this is a little fit annoying!