Remove the fail-fast option in pre-commit, fix existing issues#749
Remove the fail-fast option in pre-commit, fix existing issues#749
Conversation
|
Added the pre-commit ci job so it runs in CI and check, fast fail was not the only culprit. |
|
The exit with error code 2 and no indication is very annoying, do you know how to fix this @sbrunner ? |
00f74fc to
1bd83db
Compare
|
I found the test module which caused an issue, but I didn't succeed in finding the exact cause of the error, and I should stop for this evening! |
|
I think there's an underlying issue in requirement_detector because the directory structure is like this: And we're trying to reach |
0d02a9d to
39eb520
Compare
7a93a1c to
e0b0e26
Compare
|
I get a pretty nice solution! |
| - types-PyYAML | ||
| args: | ||
| - --summary-only | ||
| - --zero-exit |
There was a problem hiding this comment.
By the way, why do we use this argument?
There was a problem hiding this comment.
My guess is that the output of prospector messed with the output of pre-commit without it. Either causes formatting issues or drowns out other hook problems? I don't remember, maybe I didn't add it. I have no preference either way.
There was a problem hiding this comment.
Ok, I will try to remove it in another pull request :-)
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Great ! I suggested an optimisation as we launcher the other hooks with pre-commit ci.
e0b0e26 to
86c045e
Compare
86c045e to
b7a0209
Compare
Apparently the fail-fast option permitted for some error to go unfixed.