Skip to content

Delete long_path_not_a_venv since not necessary#745

Merged
sbrunner merged 1 commit intoprospector-dev:masterfrom
julianpollmann:fix/test-long-path-on-windows
Apr 1, 2025
Merged

Delete long_path_not_a_venv since not necessary#745
sbrunner merged 1 commit intoprospector-dev:masterfrom
julianpollmann:fix/test-long-path-on-windows

Conversation

@julianpollmann
Copy link
Copy Markdown
Contributor

@julianpollmann julianpollmann commented Mar 31, 2025

Description

Cloning on Windows/using pre-commit hook results in an error for long filename (#744) in tests/finder/testdata/venvs/long_path_not_a_venv/.... Also tests failed for Windows.
Configuring git with git config --system core.longpaths true solves the problem for cloning, it will however not solve the usage as a pre-commit hook.

Motivation and Context

For testing pathutils the current Test does not use the folder in testdata (also due to a typo in L36 "is_a_venv"). The path is just passed to the is_virtualenv method. Therefore i suggest to just delete the long_path_not_a_venv and its subfolders.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbrunner sbrunner merged commit 1579fe4 into prospector-dev:master Apr 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants