Skip to content

Also check Python scripts with a valid shebang#732

Merged
sbrunner merged 1 commit intomasterfrom
check-scripts
Mar 12, 2025
Merged

Also check Python scripts with a valid shebang#732
sbrunner merged 1 commit intomasterfrom
check-scripts

Conversation

@sbrunner
Copy link
Copy Markdown
Member

@sbrunner sbrunner commented Mar 7, 2025

Description

Also check Python scripts with a valid shebang

Motivation and Context

Be able to check the Python scripts that didn't end with .py.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner force-pushed the check-scripts branch 7 times, most recently from 97a0c7e to 2b478d2 Compare March 7, 2025 17:16
@sbrunner sbrunner marked this pull request as ready for review March 7, 2025 17:21
Copy link
Copy Markdown
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to add a bunch of test files with various shebang to test it maybe ?

@sbrunner sbrunner force-pushed the check-scripts branch 5 times, most recently from aefdb88 to 68c0f0f Compare March 12, 2025 11:56
@sbrunner
Copy link
Copy Markdown
Member Author

@Pierre-Sassoulas Tests added :-)

@sbrunner sbrunner merged commit 0021297 into master Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants