Conversation
e232918 to
4b1f364
Compare
| _PYLINT_EQUIVALENTS = { | ||
| # TODO: blending has this info already? | ||
| "unused-import": ( | ||
| ("pyflakes", "FL0001"), | ||
| ("frosted", "E101"), | ||
| ) | ||
| } |
prospector/tools/ruff/__init__.py
Outdated
| _IGNORE_RE = re.compile(r"#\s*noqa:([^#]*[^# ])(?:\s*#.*)?$", re.IGNORECASE) | ||
|
|
There was a problem hiding this comment.
Might want to add this to the ToolBase class for clarity ?
There was a problem hiding this comment.
The change is nice but I meant add the regex as an attribute in the ToolBase class to specify the regex for a tool noqa/disable explicitly (make it part of the ToolBase's API instead of creating a constant for each tool).
There was a problem hiding this comment.
Like the new commit?
I'm nor relay convinced, but it does the job :-)
(I should update the tests!)
There was a problem hiding this comment.
Yeap ! My reasoning is that the regex is strongly linked to a particular tool, but I don't mind if you revert, it's a nit.
There was a problem hiding this comment.
Yes, but how we use the regexp can also be linked to the tool :-)
4b1f364 to
8930755
Compare
50199ad to
8930755
Compare
Description
When one of the blended messages is ignored, ignore the other.
Related Issue
Fix #720
Motivation and Context
How Has This Been Tested?
New tests added
Types of changes