Merged
Conversation
7efadf4 to
ea404a3
Compare
ea404a3 to
9123570
Compare
9123570 to
31eb3f6
Compare
Pierre-Sassoulas
approved these changes
Nov 14, 2024
|
|
||
| # group messages by file and then line number | ||
| msgs_grouped: dict[Path, dict[int, list[Message]]] = defaultdict(lambda: defaultdict(list)) | ||
| msgs_grouped: dict[Optional[Path], dict[Optional[int], list[Message]]] = defaultdict(lambda: defaultdict(list)) |
Collaborator
There was a problem hiding this comment.
nit:Path |None will work if we import annotations from __future__, right ?
Member
Author
There was a problem hiding this comment.
I don't know, personally, I prefer waiting for Python 3.10 witch supports that natively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we get:
The new output with pylint output will be:
How Has This Been Tested?
Tested on error with all outputs!
Types of changes