Conversation
Collaborator
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM, but @carlio knows best
carlio
approved these changes
Jan 8, 2025
Member
|
Sorry I didn't spot the review request! |
Member
|
I don't know mypy that well so I'll trust that these are good default options :-) The idea is that "less strict" profiles turn off or override the behaviour of the strictest ones, beyond that the attitude is that the default "medium" should not be so strict that it annoys users. I didn't want to put people off the idea of static analysis by drowning them in tiny problems immediately. This was a response to a particular colleague to responded to Java linting with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't know how you manage the profiles, but those can be useful options for mypy,
what do you think?