feat: allows Probes to configure HTTP settings#8461
feat: allows Probes to configure HTTP settings#8461simonpasquier merged 1 commit intoprometheus-operator:release-0.90from
Conversation
| cfg = cg.addTLStoYaml(cfg, s, mergeSafeTLSConfigWithScrapeClass(m.Spec.TLSConfig, scrapeClass)) | ||
|
|
There was a problem hiding this comment.
This is done by addHTTPConfigToYAML already.
|
Good catch! It might even warrant a v0.90.1 patch release. Can you submit the PR against the release-0.90 branch? |
|
I changed the base of the PR, I'll rebase my commit on top of this branch as well. |
Signed-off-by: Jonathan Ballet <jon@multani.info>
2034013 to
b2d239d
Compare
Done ✔️
FYI, I only took a quick look at the other generator in this file, and it seems they are similar but also all slightly different ; maybe another pass over the configuration could help to have the same behavior applied everywhere. |
I'm less worried about ServiceMonitor and PodMonitor which have more test coverage in general but yes it might be worth to verify. |
3d9d543
into
prometheus-operator:release-0.90
Description
In #8112, the code was changed to unify the HTTP configuration, but the configuration was never applied to probes. For instance, changing the HTTP configuration to use HTTP 1.1 instead of HTTP 2.0 was not correctly applied.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
The new test shows the configuration with one of the HTTP config flag set, and correctly generated by the Operator.
Changelog entry