[kube-prometheus-stack] prom spec add thanos.image#6849
Merged
jkroepke merged 3 commits intoprometheus-community:mainfrom Apr 27, 2026
Merged
[kube-prometheus-stack] prom spec add thanos.image#6849jkroepke merged 3 commits intoprometheus-community:mainfrom
jkroepke merged 3 commits intoprometheus-community:mainfrom
Conversation
Signed-off-by: trouaux <thomas.rouaux@sap.com>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Contributor
Author
|
@jkroepke could you review this change? |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
approved these changes
Apr 27, 2026
|
This change broke argocd or helm or kustomize or whatever because now thanos image appear twice in rendered manifest if Template already allows to specify thanos image and any other specs without them being explicitly mentioned in values.yaml: |
Member
|
@spirkas Makes sense. Do you want to create an PR to revert this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
allows over writing thanos image on the CR level
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])