Revert "Use github.com/grafana/regexp instead of regexp" #835
+5
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 149efd6. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
SuperQ
requested changes
Sep 4, 2025
Member
SuperQ
left a comment
There was a problem hiding this comment.
Please post the contents of the slack discussion to an issue. Slack is not a source of record for this project.
Contributor
Author
|
@SuperQ OK will do. |
SuperQ
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert my change to use the more performant grafana/regexp, as this library shouldn't control this choice. Fixes #836.
This reverts commit 149efd6.