model: Clarify the purpose of model.NameValidationScheme#765
Merged
Conversation
bwplotka
reviewed
Mar 4, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
I would suggest stronger words around deprecation, plus some historical context. WDYT?
9499498 to
f66f612
Compare
e73f2be to
29ac4bf
Compare
There is a lot of confusion around this global variable. Clarify that it is meant to indicate that a project is aware of UTF-8 support, and that those projects should have their own flags to control validation mode. Signed-off-by: Owen Williams <owen.williams@grafana.com>
29ac4bf to
e21cfda
Compare
bwplotka
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot of confusion around this global variable. Clarify that it is meant to indicate that a project is aware of UTF-8 support, and that those projects should have their own flags to control validation mode.