Skip to content

chore: use testify instead of testing.Fatal#718

Merged
SuperQ merged 1 commit intoprometheus:mainfrom
mmorel-35:testifier/require-error
Nov 7, 2024
Merged

chore: use testify instead of testing.Fatal#718
SuperQ merged 1 commit intoprometheus:mainfrom
mmorel-35:testifier/require-error

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Nov 7, 2024

This uses testify instead of testing for t.Fatal calls

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testifier/require-error branch from 4269fac to beb99c1 Compare November 7, 2024 19:58
@mmorel-35 mmorel-35 marked this pull request as ready for review November 7, 2024 20:02
Copy link
Copy Markdown
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SuperQ SuperQ merged commit ab95209 into prometheus:main Nov 7, 2024
Comment thread assets/go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants