Don't always fetch a OAuth2 token, if the secret from a file didn't change#647
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Jun 28, 2024
multani:fix-oauth2-secret-file-refresh
Merged
Don't always fetch a OAuth2 token, if the secret from a file didn't change#647roidelapluie merged 1 commit intoprometheus:mainfrom multani:fix-oauth2-secret-file-refresh
roidelapluie merged 1 commit intoprometheus:mainfrom
multani:fix-oauth2-secret-file-refresh
Conversation
Contributor
Author
|
I pushed-force to sign the commit. |
Member
|
Thanks, LGTM, Can you rebase? |
…hange When configuring a OAuth2 client using the `client_secret_file` configuration option, the original intent of the code was to *not* forcefully refetch a token if the content of the file didn't change. However, both the test and the implementation had 2 typos and a new token token was fetched on every request through the HTTP client. Signed-off-by: Jonathan Ballet <jon@multani.info>
Contributor
Author
|
@roidelapluie I rebased on main 👍 |
roidelapluie
approved these changes
Jun 28, 2024
XSAM
referenced
this pull request
in XSAM/otelsql
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664) - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665) - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667) - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674) - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671) - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673) - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676) - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679) - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681) - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682) #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - [@​ilius](https://togithub.com/ilius) made their first contribution in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/XSAM/otelsql). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector
Aug 28, 2024
) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664) - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665) - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667) - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674) - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671) - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673) - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676) - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679) - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681) - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682) #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - [@​ilius](https://togithub.com/ilius) made their first contribution in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Aug 29, 2024
…6059) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://togithub.com/tjhop) in [https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677) #### New Contributors - [@​tjhop](https://togithub.com/tjhop) made their first contribution in [https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677) **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664) - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665) - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667) - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674) - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671) - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673) - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676) - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679) - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681) - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682) #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - [@​ilius](https://togithub.com/ilius) made their first contribution in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go
Aug 29, 2024
…5748) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://togithub.com/tjhop) in [https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677) #### New Contributors - [@​tjhop](https://togithub.com/tjhop) made their first contribution in [https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677) **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664) - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665) - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667) - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674) - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671) - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673) - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676) - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679) - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681) - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682) #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647) - [@​ilius](https://togithub.com/ilius) made their first contribution in [https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662) - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675) - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670) **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring a OAuth2 client using the
client_secret_fileconfiguration option, the original intent of the code was to not forcefully refetch a token if the content of the file didn't change.However, both the test and the implementation had 2 typos and a new token token was fetched on every request through the HTTP client:
secretconfigured ; in the case of a secret coming from a file, the secret kept in the state was always empty and would never match the content of the file (except if the file contains nothing, in which case the authentication couldn't proceed anyway).I extracted the secret variable from the tests to make it, hopefully, a bit clearer to see it's actual type.