feat: add time template helpers#627
Merged
gotjosh merged 9 commits intoprometheus:mainfrom Jun 3, 2024
Merged
Conversation
a629df0 to
ca27390
Compare
Contributor
Author
|
@gotjosh can you look at this? |
beorn7
reviewed
May 8, 2024
a6324bf to
b0dc45a
Compare
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
b0dc45a to
270171b
Compare
|
Hi @freak12techno, in the old PR prometheus/alertmanager#3720 you also included time.since. Is it possible to add here? |
Contributor
Author
|
@LMantovan I'll still need to make a PR towards alertmanager to use this template, my plan is to add time.Since in the next PR which will supersede the one I closed. This one needs to be merged first regardless though. |
Contributor
Author
|
@gotjosh ping? |
Member
|
@gotjosh are you up to reviewing this? Either way, could you comment so that we at least know you have seen this PR? |
Member
|
I apologise for missing the notifications for these - like everyone else, managing Github notifications has become an impossible task at this point.
EDIT: I already reviewed. |
gotjosh
reviewed
Jun 3, 2024
gotjosh
requested changes
Jun 3, 2024
Member
gotjosh
left a comment
There was a problem hiding this comment.
Looks great @freak12techno - apologies for the wait 🙏 , I've dropped some comments but all of them a very minor. If you could please address them I'd be thankful if not, I'll do it myself and merge this - just let me know.
Member
There was a problem hiding this comment.
I think we should have a single file containing everything, we call it time.go under helpers/template/time.go then we can have the tests file adjusted to be time_test.go.
Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Sergey <83376337+freak12techno@users.noreply.github.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Sergey <83376337+freak12techno@users.noreply.github.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Sergey <83376337+freak12techno@users.noreply.github.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
Contributor
Author
|
@gotjosh done, can you review? |
gotjosh
approved these changes
Jun 3, 2024
Member
gotjosh
left a comment
There was a problem hiding this comment.
LGTM
Lovely stuff, appreciate your quick turn around .
Member
|
@freak12techno thank you very much for your contribution 🙏 |
Contributor
Author
|
@gotjosh can you bump a new version of this repo so I can use it in alertmanager (and I guess in prometheus as well)? |
Member
|
@ArthurSens can you help me bump a new patch version? Is it the same process as other repositories? TIA. |
Member
|
I think I've figured it out - you should be good to go @freak12techno. |
Member
|
Yeah, there's no release process here as far as I know. Just go to the release pages and do things manually :) |
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go
Jun 3, 2024
…5472) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://togithub.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/624](https://togithub.com/prometheus/common/pull/624) - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/623](https://togithub.com/prometheus/common/pull/623) - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/416](https://togithub.com/prometheus/common/pull/416) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/633](https://togithub.com/prometheus/common/pull/633) - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/632](https://togithub.com/prometheus/common/pull/632) - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/628](https://togithub.com/prometheus/common/pull/628) - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/630](https://togithub.com/prometheus/common/pull/630) - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/631](https://togithub.com/prometheus/common/pull/631) - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/629](https://togithub.com/prometheus/common/pull/629) - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/538](https://togithub.com/prometheus/common/pull/538) - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/572](https://togithub.com/prometheus/common/pull/572) - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/636](https://togithub.com/prometheus/common/pull/636) - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/638](https://togithub.com/prometheus/common/pull/638) - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/639](https://togithub.com/prometheus/common/pull/639) - feat: add time template helpers by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) #### New Contributors - [@​bwplotka](https://togithub.com/bwplotka) made their first contribution in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - [@​freak12techno](https://togithub.com/freak12techno) made their first contribution in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Jun 3, 2024
…5709) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://togithub.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/624](https://togithub.com/prometheus/common/pull/624) - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/623](https://togithub.com/prometheus/common/pull/623) - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/416](https://togithub.com/prometheus/common/pull/416) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/633](https://togithub.com/prometheus/common/pull/633) - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/632](https://togithub.com/prometheus/common/pull/632) - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/628](https://togithub.com/prometheus/common/pull/628) - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/630](https://togithub.com/prometheus/common/pull/630) - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/631](https://togithub.com/prometheus/common/pull/631) - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/629](https://togithub.com/prometheus/common/pull/629) - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/538](https://togithub.com/prometheus/common/pull/538) - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/572](https://togithub.com/prometheus/common/pull/572) - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/636](https://togithub.com/prometheus/common/pull/636) - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/638](https://togithub.com/prometheus/common/pull/638) - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/639](https://togithub.com/prometheus/common/pull/639) - feat: add time template helpers by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) #### New Contributors - [@​bwplotka](https://togithub.com/bwplotka) made their first contribution in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - [@​freak12techno](https://togithub.com/freak12techno) made their first contribution in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector
Jun 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://togithub.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/624](https://togithub.com/prometheus/common/pull/624) - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/623](https://togithub.com/prometheus/common/pull/623) - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/416](https://togithub.com/prometheus/common/pull/416) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/633](https://togithub.com/prometheus/common/pull/633) - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/632](https://togithub.com/prometheus/common/pull/632) - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/628](https://togithub.com/prometheus/common/pull/628) - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/630](https://togithub.com/prometheus/common/pull/630) - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/631](https://togithub.com/prometheus/common/pull/631) - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/629](https://togithub.com/prometheus/common/pull/629) - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/538](https://togithub.com/prometheus/common/pull/538) - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/572](https://togithub.com/prometheus/common/pull/572) - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/636](https://togithub.com/prometheus/common/pull/636) - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/638](https://togithub.com/prometheus/common/pull/638) - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/639](https://togithub.com/prometheus/common/pull/639) - feat: add time template helpers by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) #### New Contributors - [@​bwplotka](https://togithub.com/bwplotka) made their first contribution in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - [@​freak12techno](https://togithub.com/freak12techno) made their first contribution in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 4, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://togithub.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/624](https://togithub.com/prometheus/common/pull/624) - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/623](https://togithub.com/prometheus/common/pull/623) - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://togithub.com/roidelapluie) in [https://github.com/prometheus/common/pull/416](https://togithub.com/prometheus/common/pull/416) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/633](https://togithub.com/prometheus/common/pull/633) - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/632](https://togithub.com/prometheus/common/pull/632) - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/628](https://togithub.com/prometheus/common/pull/628) - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/630](https://togithub.com/prometheus/common/pull/630) - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/631](https://togithub.com/prometheus/common/pull/631) - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/629](https://togithub.com/prometheus/common/pull/629) - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/538](https://togithub.com/prometheus/common/pull/538) - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://togithub.com/TheSpiritXIII) in [https://github.com/prometheus/common/pull/572](https://togithub.com/prometheus/common/pull/572) - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://togithub.com/bwplotka) in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/636](https://togithub.com/prometheus/common/pull/636) - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/638](https://togithub.com/prometheus/common/pull/638) - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/639](https://togithub.com/prometheus/common/pull/639) - feat: add time template helpers by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) #### New Contributors - [@​bwplotka](https://togithub.com/bwplotka) made their first contribution in [https://github.com/prometheus/common/pull/634](https://togithub.com/prometheus/common/pull/634) - [@​freak12techno](https://togithub.com/freak12techno) made their first contribution in [https://github.com/prometheus/common/pull/627](https://togithub.com/prometheus/common/pull/627) **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from here https://github.com/prometheus/prometheus/blob/34ee8c607809cca973a1d7383713035045f681d8/template/template.go#L267, the eventual goal is to reuse it in Alertmanager as well to allow it as a template helper, and also in Prometheus.
Related: prometheus/alertmanager#3717
Related: prometheus/alertmanager#3720 (comment)
Function itself is moved as is, tests are updated as there's no templates rendering here.
Also
added theadded the go.mod entry to go.mod and go.sum (otherwise.ideato.gitignore(as I use Goland IDE and it creates some files that are probably not to be committed) andmake testwould fail).