version: add Go build tags to output#455
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Mar 6, 2023
Merged
Conversation
Build tags allow different implementations of code sections to be included in the binary, so can be important to understand the exact behaviour expected at runtime. This change includes build tags at the end of the `BuildContext` string, and as an extra label on the info metric. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
SuperQ
reviewed
Feb 25, 2023
| func computeRevision() (string, string) { | ||
| var ( | ||
| rev = "unknown" | ||
| tags = "unknown" |
Member
There was a problem hiding this comment.
Wouldn't this be none if we're building with no tags?
Member
There was a problem hiding this comment.
I am fine with unknown, maybe this can be removed by the compiler? let's proceed as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build tags allow different implementations of code sections to be included in the binary, so can be important to understand the exact behaviour expected at runtime.
This change includes build tags at the end of the
BuildContextstring, and as an extra label on the info metric.Example output when linked into Prometheus: