Conversation
This was referenced Jan 31, 2023
Member
tarunKoyalwar
left a comment
There was a problem hiding this comment.
@Mzack9999 couple of things to confirms
- is this still perceived ?? based on the comments it doesnot seem to be projectdiscovery/clistats#20 (comment)
- what do you think of using
ReadConsoleInputinstead of getting and setting modes in windows ref:https://learn.microsoft.com/en-us/windows/console/readconsoleinput and https://github.com/eiannone/keyboard/blob/master/keyboard_windows.go
will review this based on response since this requires some knowledge of low level terminal syscall stuff
Member
Author
I'd suggest eventually to perform the review on code correctness level, as runtime usage for now seems very limited |
Member
Author
|
Merging - The PR mainly adds two new strings helpers and implements a generic library to set the raw mode for console with a prototype of keypress_reader (which reads from stdin without buffering) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isprintable/isctrlcstring helpers - Closes Add more string helpers #64Potentially Cover Nuclei stats display upon keypress (space) nuclei#2811
Potentially Cover using spacebar instead of enter for stats invocation clistats#20
Potentially Cover key invocation doesn't work when stdin is utilized by other options clistats#19